Only process the ping-pong monitoring in the DQM for runs acquired with FEB v6#355
Open
jlenain wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 45.43% 45.41% -0.03%
==========================================
Files 90 90
Lines 9076 9079 +3
==========================================
- Hits 4124 4123 -1
- Misses 4952 4956 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alessandromontanari
approved these changes
Jul 8, 2026
alessandromontanari
left a comment
Contributor
There was a problem hiding this comment.
Hi @jlenain, I tested this locally, and it works fine for me. It gracefully discards runs acquired with FEB v5; therefore, I am fine with this if clause for the ping-pong test. I'm still not sure, though, whether we should try to address the latest comment from Amelie in #344: #344 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this PR fixes the issue #344.