Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(schema-compiler): move preAggregations class to typescript #9538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

chore(schema-compiler): move preAggregations class to typescript #9538

wants to merge 5 commits into from

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 1, 2025 •
edited
Loading

Finally, move PreAggregations from js to ts with most of the types described! πŸŽ‰

Also switching to TS uncovered some incorrectness that is now fixed!

@codecov Codecov
Copy link

codecov bot commented May 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.50000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (00a589f) to head (c54aa36).

Files with missing lines Patch % Lines
...ejs-schema-compiler/src/adapter/PreAggregations.ts 81.42% 10 Missing and 3 partials ⚠️
...es/cubejs-schema-compiler/src/adapter/HiveQuery.ts 0.00% 3 Missing ⚠️
...s/cubejs-schema-compiler/src/adapter/BaseFilter.ts 0.00% 1 Missing ⚠️
...bejs-schema-compiler/src/adapter/CubeStoreQuery.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (00a589f) and HEAD (c54aa36). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (00a589f) HEAD (c54aa36)
cube-backend 10 1
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9538      +/-   ##
==========================================
- Coverage   61.71%   56.58%   -5.13%     
==========================================
  Files         174      165       -9     
  Lines       14432    13607     -825     
  Branches     2464     2392      -72     
==========================================
- Hits         8907     7700    -1207     
- Misses       5156     5578     +422     
+ Partials      369      329      -40
Flag Coverage Ξ”
cube-backend 56.58% <77.50%> (-5.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review May 2, 2025 08:02
@KSDaemon KSDaemon requested review from a team as code owners May 2, 2025 08:02
@KSDaemon KSDaemon mentioned this pull request May 2, 2025
Open
4 tasks
@KSDaemon KSDaemon force-pushed the chore/preaggs-2-ts branch from 18237b0 to c54aa36 Compare May 7, 2025 16:04
ovr
ovr approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@ovr ovr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”₯ Awesome! Great to see that it finally happens and TS is here for pre-aggs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovr ovr ovr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KSDaemon @ovr