Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(schema-compiler): Fix filtering by time measure #9544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2025
Merged

fix(schema-compiler): Fix filtering by time measure #9544

merged 2 commits into from
May 7, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented May 6, 2025 •
edited
Loading

Fixes errors for queries with measures with type time used as date filters.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

Closes #9435

@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.32%. Comparing base (1deddcc) to head (8069c96).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...s/cubejs-schema-compiler/src/adapter/BaseFilter.ts 33.33% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (1deddcc) and HEAD (8069c96). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1deddcc) HEAD (8069c96)
cubesql 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #9544       +/-   ##
===========================================
- Coverage   80.39%   57.32%   -23.07%     
===========================================
  Files         395      165      -230     
  Lines       97932    13558    -84374     
  Branches     2278     2279        +1     
===========================================
- Hits        78731     7772    -70959     
+ Misses      18893     5477    -13416     
- Partials      308      309        +1
Flag Coverage Δ
cube-backend 57.32% <33.33%> (-0.02%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review May 6, 2025 17:36
@KSDaemon KSDaemon requested a review from a team as a code owner May 6, 2025 17:36
@ovr ovr requested a review from waralexrom May 7, 2025 12:27
@KSDaemon KSDaemon merged commit 00a589f into master May 7, 2025
61 checks passed
@KSDaemon KSDaemon deleted the fix/time-measures-filter branch May 7, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovr ovr ovr left review comments

@waralexrom waralexrom waralexrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter by time measure doesn't work
3 participants
@KSDaemon @ovr @waralexrom