Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Show all test steps in progress formatter #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 17, 2025
Merged

Show all test steps in progress formatter #3029

merged 8 commits into from
Jul 17, 2025

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jul 17, 2025 •
edited
Loading

⚡️ What's your motivation?

The progress formatter historically has only ever rendered the steps from a scenario. Once hooks were added to Cucumber the progress formatter would also include failed hooks, but not other hooks. This seems rather inconsistent.

As hooks also take time to execute and may fail it makes sense to include them in the progress bar.

Not entirely coincidentally, this also makes it easier to use Cucumber messages.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje
[Core] Show all steps in progress formatter
cff43ee 
The progress formatter historically has only ever rendered steps. Once
hooks were added to Cucumber the progress formatter would also include
failed hooks, but not other hooks. This seems rather inconsistent.

As hooks also take time to execute and may fail it makes sense to
include them in the progress bar.

Not entirely coincidently, this also makes it easier to use Cucumber
messages.
@mpkorstanje
Update CHANGELOG
96b4ce3
@mpkorstanje mpkorstanje mentioned this pull request Jul 17, 2025
Open
11 tasks
@mpkorstanje mpkorstanje changed the title [Core] Show all steps in progress formatter Show all steps in progress formatter Jul 17, 2025
@mpkorstanje mpkorstanje marked this pull request as ready for review July 17, 2025 14:25
@mpkorstanje mpkorstanje changed the title Show all steps in progress formatter Show all test steps in progress formatter Jul 17, 2025
@mpkorstanje mpkorstanje merged commit 72ba893 into main Jul 17, 2025
6 checks passed
@mpkorstanje mpkorstanje deleted the message-based-progress-formatter branch July 17, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpkorstanje