Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support for transposed tables #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2013
Merged

Support for transposed tables #635

merged 5 commits into from
Dec 11, 2013

Conversation

rlogiacco
Copy link

In reference to issue #382 Provide support for Data Tables with headings along the side this changes add a transpose() and a @Transpose annotation.

aslakhellesoy
aslakhellesoy reviewed Nov 23, 2013
View reviewed changes
core/src/main/java/cucumber/api/DataTable.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space indent, no tabs please

@rlogiacco
Copy link
Author

Pushed two more commits trying to fulfill code conventions and to implement table balancing verification as suggested. Transpose annotation is still present as I believe it provides some nice feature.

@rlogiacco
Copy link
Author

@aslakhellesoy Is anything I can do here to move this forward?

@aslakhellesoy
Copy link
Contributor

LGTM. @brasmusson can you take a second look and merge this in?

@brasmusson
Copy link
Contributor

@aslakhellesoy Yes, I'll will take care of it.

brasmusson added a commit that referenced this pull request Dec 11, 2013
@brasmusson
Merge #635, which fixes #382. Update History.md.
4baca3d
@brasmusson brasmusson merged commit 0c37374 into cucumber:master Dec 11, 2013
@brasmusson
Copy link
Contributor

Merged. Thanks for your contribution @rlogiacco.

@rlogiacco
Copy link
Author

Proud of having had the opportunity to help!

;)

Il giorno mercoledì 11 dicembre 2013, Björn Rasmusson ha scritto:

Merged. Thanks for your contribution @rlogiaccohttps://github.com/rlogiacco
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/635#issuecomment-30362654
.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlogiacco @aslakhellesoy @brasmusson