Fix repeated step arguments #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c50971a to
c251e4e
Compare
mpkorstanje
commented
Aug 19, 2025
|
I don't have time to wrap this up. We definitively need a more complicated example with a regular expression in the CCK. Needs a changelog too. |
a8374ff to
6e8dd39
Compare
davidjgoss
approved these changes
Aug 28, 2025
The Javascript implementation didn't quite follow the Java implementation. Specifically it would append the plain text but then only advance the current index if there was an argument. Partially fixes cucumber/cucumber-js#2620
6e8dd39 to
e4a8da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The Javascript implementation didn't quite follow the Java implementation. Specifically it would append the plain text but then only advance the current index if there was an argument.
Fixed this and also updated the Java implementation for clarity and parity.
⚡️ What's your motivation?
Partially fixes cucumber/cucumber-js#2620
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
See below.
📋 Checklist: