Add cupyx.signal.{firfilter,firfilter_zi,firfilter2}#8052
Merged
Conversation
Contributor
|
This pull request is now in conflicts. Could you fix it @emcastillo? 🙏 |
3256b01 to
ea6dad4
Compare
Member
|
/test mini |
Contributor
|
This pull request is now in conflicts. Could you fix it @emcastillo? 🙏 |
Member
|
/test mini |
asi1024
reviewed
Dec 29, 2023
| be 1; the trivial dimension is not removed. (Use numpy.squeeze() | ||
| to remove trivial axes.) | ||
| """ | ||
| a = cupy.asarray(a) |
Member
There was a problem hiding this comment.
Suggested change
| a = cupy.asarray(a) |
| @pytest.mark.parametrize('dtype', [cupy.float32, cupy.float64]) | ||
| @pytest.mark.parametrize("num_samps", [2**14, 2**18]) | ||
| @pytest.mark.parametrize("filter_len", [8, 32, 128]) | ||
| def test_firfilter(dtype, num_samps, filter_len): |
Member
There was a problem hiding this comment.
Could you parametrize with pad_type: ["odd, "even", "constant"]?
Member
Author
There was a problem hiding this comment.
I think pad is supported only on firfilter2 routine. I will add it there!!
| b = cupy.array(b, dtype=dtype) | ||
| x = cupy.array(x, dtype=dtype, copy=False) | ||
|
|
||
| out_full = cupy.apply_along_axis(lambda y: cupy.convolve(b, y), axis, x) |
Member
There was a problem hiding this comment.
note: fft(b) is computed in duplicate.
Member
|
Duplicate of |
1393811 to
dbc7d2a
Compare
Member
|
/test mini |
asi1024
approved these changes
Jan 12, 2024
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Jan 12, 2024
Add `cupyx.signal.{firfilter,firfilter_zi,firfilter2}`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From cuSignal non scipy API