Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate cupyx.scipy wavelet functions#8061

Merged
asi1024 merged 3 commits into
cupy:mainfrom
asi1024:wavelet-deprecation
Jan 24, 2024
Merged

Deprecate cupyx.scipy wavelet functions#8061
asi1024 merged 3 commits into
cupy:mainfrom
asi1024:wavelet-deprecation

Conversation

@asi1024

@asi1024 asi1024 commented Dec 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #8046.
According to the SciPy 1.12 release notes, all wavelet functions will be deprecated and it is recommended to use PyWavelets instead. Should we move the wavelet functions from cupyx.signal to the cupyx.pywt namespace?

@kmaehashi

kmaehashi commented Jan 5, 2024

Copy link
Copy Markdown
Member

Thanks for catching up with the SciPy 1.12 changes!

Should we move the wavelet functions from cupyx.signal to the cupyx.pywt namespace?

This sounds a rescope of our project. Since we don't have a plan to host PyWavelet functions in CuPy (as of now, at least), I'm opposed to introducing the new namespace. I think it's ok to mark these APIs deprecated like we had done in the past cases.

If someone really wants the GPU version of wavelet functions after SciPy removes them, we can move them to cupyx.signal namespace which hosts non-SciPy compatible signal processing routines. I think it's nice to include a link to this PR (or another "RFC" issue) in the DeprecationWarning message to know if there is a user who wants them.

@asi1024 asi1024 force-pushed the wavelet-deprecation branch from 40d18dc to 520476a Compare January 9, 2024 07:57
@asi1024 asi1024 changed the title [RFC] Fix for wavelet functions deprecation from SciPy 1.12 Fix for wavelet functions deprecation from SciPy 1.12 Jan 9, 2024
@asi1024 asi1024 marked this pull request as ready for review January 9, 2024 07:58
@asi1024 asi1024 changed the title Fix for wavelet functions deprecation from SciPy 1.12 Deprecate cupyx.scipy wavelet functions Jan 9, 2024
@asi1024 asi1024 changed the title Deprecate cupyx.scipy wavelet functions Deprecate cupyx.scipy wavelet functions Jan 9, 2024
@asi1024 asi1024 added cat:numpy-compat Follow the NumPy/SciPy spec changes to-be-backported Pull-requests to be backported to stable branch prio:medium labels Jan 9, 2024
@kmaehashi kmaehashi self-assigned this Jan 9, 2024
@kmaehashi kmaehashi added this to the v14.0.0a1 milestone Jan 9, 2024
@asi1024 asi1024 mentioned this pull request Jan 21, 2024
Merged
kmaehashi
kmaehashi previously approved these changes Jan 24, 2024
View reviewed changes

@kmaehashi kmaehashi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the minor message comment. Please proceed to merge after test pass.

Comment thread cupyx/scipy/signal/_wavelets.py Outdated


_deprecate_msg = (
"All wavelet functions have been deprecated since CuPy v14. "

@kmaehashi kmaehashi Jan 24, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding more info like this?

Following the change in SciPy 1.12, all wavelet functions have been deprecated in CuPy v14 and are planned to be removed in the future.

@asi1024

asi1024 commented Jan 24, 2024

Copy link
Copy Markdown
Member Author

/test mini,head

@asi1024 asi1024 enabled auto-merge January 24, 2024 05:24
@asi1024 asi1024 merged commit 37602b2 into cupy:main Jan 24, 2024
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jan 24, 2024
@asi1024 @chainer-ci
Merge pull request cupy#8061 from asi1024/wavelet-deprecation
1b60dfa 
Deprecate `cupyx.scipy` wavelet functions
@chainer-ci chainer-ci mentioned this pull request Jan 24, 2024
Merged
@asi1024 asi1024 deleted the wavelet-deprecation branch January 25, 2024 00:50
This was referenced Jan 7, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels

cat:numpy-compat Follow the NumPy/SciPy spec changes prio:medium to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v14.0.0a1

Development

Successfully merging this pull request may close these issues.

2 participants

@asi1024 @kmaehashi