Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add batched solve_triangular#8329

Merged
takagi merged 7 commits into
cupy:mainfrom
Berrysoft:batched-trsm
May 31, 2024
Merged

Add batched solve_triangular#8329
takagi merged 7 commits into
cupy:mainfrom
Berrysoft:batched-trsm

Conversation

@Berrysoft

Copy link
Copy Markdown
Contributor

It is not implemented in scipy, but I need it for my research:)

@takagi takagi added this to the v14.0.0a1 milestone May 23, 2024
@takagi

takagi commented May 23, 2024

Copy link
Copy Markdown
Contributor

/test mini

@takagi

takagi commented May 23, 2024

Copy link
Copy Markdown
Contributor

/test mini

@takagi

takagi commented May 29, 2024

Copy link
Copy Markdown
Contributor

/test mini

@kmaehashi kmaehashi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Berrysoft, thanks for the contribution! We usually keep our APIs compatible with SciPy ones but this sounds good addition without any breakage.

Comment thread cupyx/scipy/linalg/_solve_triangular.py
@Berrysoft

Copy link
Copy Markdown
Contributor Author

The hip used by CI seems different from mine. I'll fix it later.

@Berrysoft Berrysoft requested a review from kmaehashi May 29, 2024 19:03
@takagi

takagi commented May 30, 2024

Copy link
Copy Markdown
Contributor

/test mini

@Berrysoft

Copy link
Copy Markdown
Contributor Author

The CI failed, but it seems not my fault:

C:\Windows\TEMP\flexci\run-00332685\tmp\tmpkmrn5qje\a.cpp(1): fatal error C1083: Cannot open include file: 'nccl.h': No such file or directory

Same error message for "cutensor.h" and "cusparseLt.h".

@takagi

takagi commented May 31, 2024

Copy link
Copy Markdown
Contributor

@takagi

takagi commented May 31, 2024

Copy link
Copy Markdown
Contributor

The failure seems not to be related.

@takagi takagi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takagi takagi merged commit d8df1f0 into cupy:main May 31, 2024
@Berrysoft Berrysoft deleted the batched-trsm branch May 31, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants