Resolve Ruff NPY errors - fix exception imports and asfarray usage in test code#8455
Merged
Conversation
Member
|
cc @seberg (in case you have thought on this 🙂) |
jakirkham
reviewed
Aug 8, 2024
jakirkham
left a comment
Member
There was a problem hiding this comment.
Thanks Earl! 🙏
Generally this seems reasonable. Using cupy.exceptions module in more places
Had one question below
Member
|
/test mini |
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Aug 10, 2024
Resolve Ruff `NPY` errors
Member
|
Thanks all! 🙏 |
NPY errorsNPY errors - fix exception imports and asfarray usage in test code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8454