Get rid of pkg_resources#8480
Merged
Merged
Conversation
Member
|
/test mini |
kmaehashi
reviewed
Aug 13, 2024
Member
|
Could you please add issue ( #7654 ) to the fixed issues in the top-level post of this PR? |
jakirkham
reviewed
Aug 13, 2024
jakirkham
left a comment
Member
There was a problem hiding this comment.
Perhaps something like this would work?
Co-authored-by: jakirkham <[email protected]>
f06b34e to
429af64
Compare
Member
|
/test mini |
Member
|
Sorry was bit by a |
Member
|
Seeing a few errors on CI /opt/pyenv/versions/3.11.0/lib/python3.11/importlib/metadata/__init__.py:561: in from_name
raise PackageNotFoundError(name)
E importlib.metadata.PackageNotFoundError: No package metadata was found for opencv-python/opt/pyenv/versions/3.11.0/lib/python3.11/importlib/metadata/__init__.py:561: in from_name
raise PackageNotFoundError(name)
E importlib.metadata.PackageNotFoundError: No package metadata was found for matplotlibMaybe we need to tweak the logic in the package check somehow? |
Contributor
Author
|
I submitted a fix in 9efd74d. |
jakirkham
reviewed
Aug 14, 2024
jakirkham
left a comment
Member
There was a problem hiding this comment.
Thank you! 🙏
That seems like a good fix
Had a minor suggestion on imports
Member
|
/test mini |
Member
|
/test mini |
jakirkham
approved these changes
Aug 14, 2024
Member
|
Thanks for all of your work here! 🙏 Looks like it is now passing 🥳 Let's see what Kenichi thinks 🙂 |
Member
|
Thanks @EarlMilktea and @jakirkham, LGTM! |
kmaehashi
approved these changes
Aug 15, 2024
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Aug 15, 2024
Get rid of `pkg_resources`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8479 and #7654.