Support setuptools 74.0.0 or later#8583
Merged
Merged
Conversation
Member
Author
|
Oops, I just noticed |
Contributor
|
/test mini |
cl.exe at runtime with setuptools 74cl.exe at runtime with setuptools 74.0.0
cl.exe at runtime with setuptools 74.0.0cl.exe at runtime with setuptools 74.0.0 or later
Member
Author
|
/test mini |
Member
Author
|
Changing priority to high as this impacts Windows users with setuptools 74.0.0+. |
cl.exe at runtime with setuptools 74.0.0 or later
Member
Author
|
/test mini |
Contributor
|
This pull request is now in conflicts. Could you fix it @kmaehashi? 🙏 |
Member
Author
|
/test mini This one is review ready! |
Contributor
|
/test mini |
Member
Author
|
/test mini |
Member
|
@takagi Failed to backport automatically. |
Member
|
@takagi This pull-request is marked as |
kmaehashi
pushed a commit
to kmaehashi/cupy
that referenced
this pull request
Oct 7, 2024
Support setuptools 74.0.0 or later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8568. Follows-up #8574. Reverts #8567.
edit: This PR adopts recent setuptools changes, specifically v74.0.0 (which removed
setuptools.msvc) and v74.1.0+ (which revertedsetuptools.msvcbut requires explicit module import instead ofimport setuptools).Original description
On Windows platform with setuptools 74+, it will now take 2-3 seconds to find
cl.exe. This overhead happens only once per process, and only when the use ofnvccis requested.setuptools.msvc(which we rely on for years and is now removed) was able to discovercl.exevery quickly as it directly reads the Windows registry. The new approach introduced in this PR (which only uses the public/documented setuptools API) retrives the compiler path throughvcvarsall.bat, which incurs subprocess invocation.