Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add NCCL_ERROR_REMOTE_ERROR to the set of errors from NCCL#8662

Merged
kmaehashi merged 2 commits into
cupy:mainfrom
mohitreddy1996:mohit/add-remote-error
Oct 16, 2024
Merged

Add NCCL_ERROR_REMOTE_ERROR to the set of errors from NCCL#8662
kmaehashi merged 2 commits into
cupy:mainfrom
mohitreddy1996:mohit/add-remote-error

Conversation

@mohitreddy1996

Copy link
Copy Markdown
Contributor

Error codes possible from nccl - https://github.com/NVIDIA/nccl/blob/2ea4ee94bfb04c886c79ccae60ac9961000fdee2/src/nccl.h.in#L43

Fixes/Returns a more reasonable error for #8661

Comment thread cupy_backends/cuda/libs/nccl.pyx Outdated
@kmaehashi

Copy link
Copy Markdown
Member

Thanks, LGTM!

/test mini

@asi1024 asi1024 added cat:enhancement Improvements to existing features prio:medium labels Oct 15, 2024
@kmaehashi kmaehashi enabled auto-merge October 15, 2024 05:22
@kmaehashi kmaehashi added the to-be-backported Pull-requests to be backported to stable branch label Oct 15, 2024
@kmaehashi kmaehashi added this to the v14.0.0a1 milestone Oct 15, 2024
@kmaehashi kmaehashi linked an issue Oct 15, 2024 that may be closed by this pull request
@kmaehashi kmaehashi disabled auto-merge October 16, 2024 03:10
@kmaehashi kmaehashi merged commit fb6ffd7 into cupy:main Oct 16, 2024
@kmaehashi

Copy link
Copy Markdown
Member

Test failures are unrealted. Thanks!

@kmaehashi kmaehashi changed the title cupy: add remote error to the set of errors from nccl Add NCCL_ERROR_REMOTE_ERROR to the set of errors from nccl Oct 16, 2024
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Oct 16, 2024
cupy: add remote error to the set of errors from nccl
@kmaehashi kmaehashi changed the title Add NCCL_ERROR_REMOTE_ERROR to the set of errors from nccl Add NCCL_ERROR_REMOTE_ERROR to the set of errors from NCCL Oct 16, 2024
@mohitreddy1996

Copy link
Copy Markdown
Contributor Author

Thank you @kmaehashi :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NcclCommunicator initialization fails with KeyError: 6

3 participants