Fix cupyx.scipy.special.logsumexp for NumPy 2.0#8836
Merged
Conversation
Member
Author
|
/test mini |
asi1024
commented
Jan 6, 2025
Comment on lines
63
to
+68
| if return_sign: | ||
| sgn = cp.sign(s) | ||
| s *= sgn | ||
| if s.dtype.char == 'c': | ||
| sgn = s / cp.where(s == 0, 1, cp.abs(s)) | ||
| else: | ||
| sgn = cp.sign(s) | ||
| s = cp.abs(s) |
Member
Author
There was a problem hiding this comment.
I have fixed the following changes to the SciPy 1.14 code. However, it seems that there have been further changes in SciPy 1.15.
https://github.com/scipy/scipy/blob/92d2a8592782ee19a1161d0bf3fc2241ba78bb63/scipy/special/_logsumexp.py#L122-L128
Member
Author
There was a problem hiding this comment.
The cupyx.scipy.special CIs fail in SciPy 1.15, but I want to ensure that they work in NumPy 2.x. So, I plan to fix them for SciPy 1.15 in another PR. PTAL.
5245d37 to
a626fd6
Compare
Member
Author
|
/test mini |
Member
Author
|
@kmaehashi Ready to review. |
kmaehashi
previously approved these changes
Jan 15, 2025
The merge-base changed after approval.
a626fd6 to
95ae309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8306.
Blocked by #8835.