Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable ruff rule UP#8849

Merged
kmaehashi merged 15 commits into
cupy:mainfrom
EarlMilktea:ruff-up
Jun 4, 2025
Merged

Enable ruff rule UP#8849
kmaehashi merged 15 commits into
cupy:mainfrom
EarlMilktea:ruff-up

Conversation

@EarlMilktea

@EarlMilktea EarlMilktea commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

This PR enables the UP rules, which ban deprecated/outdated codes.

MEMO

UP031 and UP032 are ignored for now because diffs. would be too large with them.

@EarlMilktea EarlMilktea marked this pull request as ready for review December 20, 2024 12:52
@asi1024 asi1024 added prio:medium cat:code-fix Code refactoring that do not change behavior labels Dec 24, 2024
kmaehashi
kmaehashi previously approved these changes May 31, 2025

@kmaehashi kmaehashi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kmaehashi kmaehashi added the to-be-backported Pull-requests to be backported to stable branch label May 31, 2025
@mergify

mergify Bot commented May 31, 2025

Copy link
Copy Markdown
Contributor

This pull request is now in conflicts. Could you fix it @EarlMilktea? 🙏

@kmaehashi

Copy link
Copy Markdown
Member

/test mini

@kmaehashi kmaehashi added this to the v14.0.0a2 milestone Jun 4, 2025
@kmaehashi kmaehashi enabled auto-merge June 4, 2025 13:39
@kmaehashi kmaehashi merged commit f27de09 into cupy:main Jun 4, 2025
64 checks passed
@chainer-ci

Copy link
Copy Markdown
Member

@kmaehashi Failed to backport automatically.


Not cleanly cherry-picked

@EarlMilktea EarlMilktea deleted the ruff-up branch June 4, 2025 16:57
@kmaehashi

Copy link
Copy Markdown
Member

@EarlMilktea Could you take care of backport to v13 branch? It can be done using backport script:

python backport.py --repo cupy --pr 8849

EarlMilktea pushed a commit to EarlMilktea/cupy that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:code-fix Code refactoring that do not change behavior prio:medium to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants