Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable contiguous_check for COO/dense matmul test#8878

Merged
kmaehashi merged 1 commit into
cupy:mainfrom
asi1024:matmul-coo-dense-contig
Jan 20, 2025
Merged

Disable contiguous_check for COO/dense matmul test#8878
kmaehashi merged 1 commit into
cupy:mainfrom
asi1024:matmul-coo-dense-contig

Conversation

@asi1024

@asi1024 asi1024 commented Jan 20, 2025

Copy link
Copy Markdown
Member

Part of #8866.

In SciPy 1.15, the result of the matrix product of COO sparse matrices and dense matrices is returned in a C-contiguous array, which is different from the behaviour in SciPy 1.14 and earlier. However, for performance reasons, CuPy should continue to return a non-contiguous array.

@asi1024 asi1024 mentioned this pull request Jan 20, 2025
8 tasks
@kmaehashi kmaehashi self-assigned this Jan 20, 2025
@kmaehashi kmaehashi added cat:numpy-compat Follow the NumPy/SciPy spec changes prio:medium labels Jan 20, 2025
@kmaehashi kmaehashi added this to the v14.0.0a1 milestone Jan 20, 2025
@kmaehashi

Copy link
Copy Markdown
Member

/test mini

@kmaehashi kmaehashi enabled auto-merge January 20, 2025 04:41
@kmaehashi kmaehashi added the to-be-backported Pull-requests to be backported to stable branch label Jan 20, 2025
@kmaehashi kmaehashi merged commit 4f4f99d into cupy:main Jan 20, 2025
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jan 20, 2025
Disable contiguous_check for COO/dense matmul test
@asi1024 asi1024 deleted the matmul-coo-dense-contig branch January 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:numpy-compat Follow the NumPy/SciPy spec changes prio:medium to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants