[v13] BUG: Hot fix for numpy 2 support in some fusion paths#9012
Merged
Conversation
Scalars are a problem, and I am not convinced that this is a complete fix (for example w.r.t. integers). OTOH v14 should already be working here I believe. But I think this is safe and could be back-portable.
Member
|
/test mini |
Member
|
Test failures are unrelated. I confirmed that 7 test cases have been resolved in this PR. Thank you for the pull request! |
asi1024
approved these changes
Mar 5, 2025
Member
|
This is |
kmaehashi
pushed a commit
to kmaehashi/cupy
that referenced
this pull request
Mar 5, 2025
[v13] BUG: Hot fix for numpy 2 support in some fusion paths
|
@asi1024 This pull-request is marked as |
|
@asi1024 This pull-request is marked as |
Member
|
This is backported to v13.4.1 in #9016. |
rapids-bot Bot
pushed a commit
to rapidsai/cucim
that referenced
this pull request
Mar 26, 2025
…els (#856) Fix for recent test failures after CuPy 13.4.1 was released as seen here: https://github.com/rapidsai/cucim/actions/runs/14052308871 There is a data type casting change in fused kernels used by `cucim.skimage.segmentation.chan_vese`. Likely this is related to the changes made in cupy/cupy#9012. We can ensure the correct output dtype from the fused kernel by making sure all float scalars used as input to the fused kernels are device scalars of the desired precision. Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - https://github.com/jakirkham URL: #856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalars are a problem, and I am not convinced that this is a complete fix (for example w.r.t. integers). OTOH v14 should already be working here, I believe.
But I think this is safe and could be back-portable.
Closes gh-8536
Need to still check if v14 is indeed fine, we may want to forward port the test to make sure.v14 is fine as expected.