Do gc.collect() in MemoryHook test code to avoid free hook to happen#9092
Merged
Conversation
gc.collect() to avoid free hook to happengc.collect() in MemoryHook test code to avoid free hook to happen
Member
Author
|
/test mini |
asi1024
approved these changes
Apr 8, 2025
chainer-ci
pushed a commit
to chainer-ci/cupy
that referenced
this pull request
Apr 8, 2025
Do `gc.collect()` in MemoryHook test code to avoid `free` hook to happen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9077
I repeatedly ran the test locally but could not reproduce the origianl issue. My guess is that Python GC has triggered somewhere between
with self.hook:andalloc_postprocess, which causedfree_postprocess(for a memory block acquired in the previous test cases) to be triggered.cupy/tests/cupy_tests/cuda_tests/memory_hooks_tests/test_debug_print.py
Lines 22 to 23 in 1e8ade1
Adding
gc.collect()tosetUpto avoidfree_*to be triggered.