Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not include files listed in MANIFEST.in to wheels#9230

Merged
kmaehashi merged 1 commit into
cupy:mainfrom
kmaehashi:fix-package-info
Jul 7, 2025
Merged

Do not include files listed in MANIFEST.in to wheels#9230
kmaehashi merged 1 commit into
cupy:mainfrom
kmaehashi:fix-package-info

Conversation

@kmaehashi

@kmaehashi kmaehashi commented Jul 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Follows up #9079. Closes #9226. For pyproject.toml, it seems all files listed in MANIFEST.in are added to wheel by default without this settings.

https://setuptools.pypa.io/en/latest/userguide/datafiles.html

To further include them into the wheels, you can use the include_package_data keyword:
...
The default value for tool.setuptools.include-package-data is true when projects are configured via pyproject.toml. This behaviour differs from setup.cfg and setup.py (where include_package_data is False by default)

@kmaehashi kmaehashi added to-be-backported Pull-requests to be backported to stable branch blocking Issue/pull-request is mandatory for the upcoming release prio:high labels Jul 4, 2025
@kmaehashi

kmaehashi commented Jul 4, 2025

Copy link
Copy Markdown
Member Author

/test mini

@kmaehashi kmaehashi added this to the v14.0.0a2 milestone Jul 4, 2025
@kmaehashi

kmaehashi commented Jul 5, 2025

Copy link
Copy Markdown
Member Author

Test failures are unrelated (#7240).

@kmaehashi kmaehashi mentioned this pull request Jul 5, 2025
Closed
@kmaehashi kmaehashi merged commit 655a8d7 into cupy:main Jul 7, 2025
68 of 70 checks passed
@kmaehashi kmaehashi deleted the fix-package-info branch July 7, 2025 13:28
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jul 7, 2025
@kmaehashi @chainer-ci
Merge pull request cupy#9230 from kmaehashi/fix-package-info
a098679 
Do not include files listed in `MANIFEST.in` to wheels
@chainer-ci chainer-ci mentioned this pull request Jul 7, 2025
Merged
@kmaehashi kmaehashi added the cat:install Build and installation label Jul 9, 2025
@kmaehashi kmaehashi mentioned this pull request Aug 15, 2025
Merged
gpinkert pushed a commit to ROCm/cupy that referenced this pull request Sep 13, 2025
@kmaehashi @gpinkert
Merge pull request cupy#9230 from kmaehashi/fix-package-info
0a04586 
Do not include files listed in `MANIFEST.in` to wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@asi1024 asi1024

Labels

blocking Issue/pull-request is mandatory for the upcoming release cat:install Build and installation prio:high to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v14.0.0rc1

Development

Successfully merging this pull request may close these issues.

Cython files and C headers are unexpectedly included in wheels

2 participants

@kmaehashi @asi1024