Lazy load the testing module#9336
Merged
Merged
Conversation
vyasr
commented
Aug 30, 2025
Member
|
/test mini |
kmaehashi
approved these changes
Sep 6, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the import time investigations I have been doing regarding #9324 and #9325 I also noticed that cupy.testing adds significant testing overhead in environments where pytest is installed. I considered making the pytest import lazy or trying to hide its cost in other ways, but ultimately I decided that since most users of cupy do not need the testing module directly the best option would be to make the testing module import in cupy's
__init__.pylazy and hide all of the overhead. The module load is fast enough that for users actually accessing the testing module the first attribute access (which triggers the load, and is therefore made slower by making this module load lazy) is still less than 0.1 s so it doesn't degrade that experience much (in exchange for making the majority use case of importing cupy without using testing faster).