Fix tf2sos failing for constant transfer function.#9395
Merged
Conversation
Member
|
/test mini |
asi1024
reviewed
Oct 30, 2025
Member
|
/test mini |
Member
|
/test mini |
leofang
approved these changes
Oct 31, 2025
asi1024
approved these changes
Nov 6, 2025
Member
|
LGTM! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9376
This PR makes
tf2soswork when a constant transfer function is passed. The problem occurred due to array construction inzpk2soswhich assumes that the system gainkis a float and fails whenkis a 0d CuPy array. To fix this, I added a check for ifkis a 0d CuPy array, and callk.get()to convert to a 0d NumPy array, which does work for such array construction. I made it check specifically for a 0d CuPy array to try to make the error message less confusing if a higher dimensional CuPy array is passed fork, e.g. to avoid an error message referring to NumPy arrays.I've also copied the tests for
tf2sosover from SciPy, including the ones that failed due to #9376.