IS-11243 Fix search input left padding#165
Open
urre wants to merge 1 commit into
Open
Conversation
… selector and scoping submit button margin.
markoweb
approved these changes
May 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes layout regressions around search inputs by tightening global form/button base styles and relocating submit-button spacing to identity-server-specific styling.
Changes:
- Removed an overly broad
input[type]...selector from shared form base styles to avoid unintended styling of non-text inputs. - Removed global
margin-block-startfrom the shared submit/button-medium rule in base button styles. - Added identity-server-specific submit-button top spacing in
login-base.css.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/identity-server/styles/css/login-base.css | Adds submit-button spacing in identity-server styles (currently applied via a global submit selector). |
| src/common/css/lib/src/base/base-forms.css | Removes the overly broad input selector from shared base form styling. |
| src/common/css/lib/src/base/base-buttons.css | Removes global submit/button-medium top margin from shared base button styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
|
|
||
| button[type="submit"] { |
luisgoncalves
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix search input left padding by removing overly broad input selector and scoping submit button margin.
I did this in a PR targeted to LWA integration branch, but should have done it against dev.