Add commercial solver default setting#3352
Merged
Merged
Conversation
| value = os.environ.get(name) | ||
| if value is None: | ||
| return default | ||
| return value.strip().lower() not in {"0", "false", "no", "off"} |
There was a problem hiding this comment.
An empty env var (CVXPY_DEFAULT_TO_COMMERCIAL_SOLVERS="") is treated as True here, since "" is not in the falsy set. Some deployment systems and CI environments set env vars to empty strings to effectively unset them, so having that silently enable commercial solver preference is surprising.
Consider adding "" to the falsy set:
return value.strip().lower() not in {"", "0", "false", "no", "off"}
Collaborator
Author
There was a problem hiding this comment.
That's absolutely my intent since we want it to default to true
|
Benchmarks that have improved:
Benchmarks that have stayed the same: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an internal env-backed setting to skip commercial solvers when choosing defaults. This is useful for local development when testing multiple solver interfaces.
Issue link (if applicable):
Type of change
Contribution checklist