bugfix: Fix #218 by serializing "null" for "null" types #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ There were two sets of similar JSON serialization logic
in place. This unifies them by just making all our custom objects
call for_json() which already does the right thing.
+ The actual bug is fixed by permitting None values to serialize
to JSON, iff the type of the object is "null"
Aside: I still don't understand why objects with _type_ null exist
in the JSONSchema spec, but w/e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside: I still don't understand why objects with type null exist
in the JSONSchema spec, but w/e.