DOM element helpers typings #601
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great initiative @whitecolor ! Keep on going with this please :) Eventually it would be good to put this in snabbdom, but Cycle.js has a unique hyperscript helper, so it makes sense to do what you're doing now. I'd also recommend writing some tests (they are in TypeScript nowadays) before implementing everything. It doesn't need to be full TDD, but just a few tests so we know what is the goal API that we want to get. |
19355d6 to
61f81cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to open this PR (will contain multiple commits), for making better typings of DOM helpers based on @TylorS's https://github.com/TylorS/mostly-dom/blob/master/src/types/HtmlProperties.ts
This will also probably require move to TS 2.3.2
@staltz please review initial changes, and say if you ok with the proposal
maybe it would be better to implement in snabbdom?