fix: save diff images only on failed tests #110
Conversation
|
@mjhea0 could you please review and approve the workflow? |
|
@Zaista - thanks for the PR! So, this implementation only saves the diff image on failed tests by default, correct? Can you please make this configurable? |
|
Correct. I thought about it, but honestly I do not see the point of making this configurable. Why would anyone need this diff image on successful test? You anyway have the actual screenshot... |
|
I'm not sure, but this changes the behavior so I'd like it to be configurable in case someone is dependent on it. |
|
@mjhea0 done |
|
@mjhea0 could you take a look on this PR please ? |
|
The fact this simple PR takes half a year is disturbing. |
|
I'm slammed and don't use this project anymore. If you'd like to step up and become a maintainer then go for it, @Zaista. I'm happy to transfer the repo to you. |
|
Yep, let's do it. I'll give it a go |
|
I just added you as a collaborator. Let's start there. |
Resolves: #108