Use relative spec path to compute the snapshot directory #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rely on cypress reported snapshot location (fix for cypress 10 changes) * move .png images rather than copying, to reduce extra files * simplify initialization with fewer global variables
* capture snapshot location for cypress 10 compatibility * revise updated version of plugins * cosmetic refactoring
|
Looks good to me. @Zaista, any thoughts? |
|
Any update on this PR? We're currently locked in the Cypress 9. |
|
Ok, tests don't work for node <14.0 as Optional chaining (?.) is not supported below. So we should reconsider the CI tests. But not to block the PR any further I'll merge it |
|
It would be great if the environment variable |
LittleIronMan
added a commit
to LittleIronMan/cypress-visual-regression
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibility with Cypress v10 and v11.
When Cypress v10 came out, the paths of generated files were changed and with that update, this lib stopped working.
An open issue (#131) reports the mismatch between paths, and based on @mighdoll fork and @csnate suggestions I am opening this PR.
The solution involves using the
Cypress.spec.relativevariable to compute the snapshot directory and adding a new environment variable namedINTEGRATION_FOLDERto remove it from the relative spec path obtaining only the desired subpath.Example: