svg: Text may overflow legend bounds when monospace font is used - #2674
Merged
Conversation
alixander
reviewed
Oct 11, 2025
alixander
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the clear report and PR!
You can add a test here:
https://github.com/terrastruct/d2/blob/master/e2etests/txtar.txt#L1072
If you use it with Terminal theme (https://github.com/terrastruct/d2/blob/master/e2etests/txtar.txt#L729), it should use the monospace font.
Everything else looks good to me
ocadaruma
force-pushed
the
fix-legend-width-on-mono
branch
from
October 12, 2025 11:57
7b07fe3 to
0abb04f
Compare
Contributor
Author
|
@alixander Thank you for your advice! I added a test. |
ocadaruma
force-pushed
the
fix-legend-width-on-mono
branch
from
October 12, 2025 23:46
0abb04f to
1ade3c2
Compare
Contributor
Author
|
I signed the commit to resolve CI failure. Could you take a look again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks a lot for providing great product as an open source!
Summary
SourceSansProfont even when mono is used.Note