Added link in image interpolation settings to more info #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2phap
requested changes
Aug 10, 2024
d2phap
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base language file and all language JSON files were updated to include variables
FrmSettings._ImageInterpolation._MoreInfoandFrmSettings._ImageInterpolation._MoreInfoLink.FrmSettings._ImageInterpolation._MoreInfowas set to “More Info” in all languages, as I am unfamiliar with foreign languages.FrmSettings._ImageInterpolation._MoreInfoLinkwas set to a Microsoft’s web page on interpolation modes, with the corresponding language set in the URL.In the FrmSettings.html, I added an
<a>element which containedlang-textandlang-hrefattributes set toFrmSettings._ImageInterpolation._MoreInfoandFrmSettings._ImageInterpolation._MoreInfoLinkrespectively.Since there was no way to process
lang-href, I also added a function call to Language.ts which processedlang-hrefattribute and updatedhrefdynamically.