docs: upgrade svelte example to use runes#4050
Open
shivan-eyespace wants to merge 1 commit intod3:mainfrom
Open
docs: upgrade svelte example to use runes#4050shivan-eyespace wants to merge 1 commit intod3:mainfrom
shivan-eyespace wants to merge 1 commit intod3:mainfrom
Conversation
mchoo7
suggested changes
Sep 20, 2025
| let x = $derived(d3.scaleLinear([0, data.length - 1], [marginLeft, width - marginRight])); | ||
| let y = $derived(d3.scaleLinear(d3.extent(data), [height - marginBottom, marginTop])); | ||
| let line = $derived(d3.line((d, i) => x(i), y)) | ||
| </script> |
| let line = d3.line((d, i) => x(i), y); | ||
| $effect(()=> d3.select(gy).call(d3.axisLeft(y))) | ||
| $effect(()=> d3.select(gx).call(d3.axisBottom(x))) | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the svelte 5 upgrade. I have decided to contribute and update the svelte example in the "Getting Started" documentation to include the rune syntax.
I also updated the playground examples. As well as removed an extraneous example and the incorrect playground.
CleanShot.2025-09-20.at.22.29.46.mp4
Keen for any feedback and hope this helps.