2.0 #41
Closed
2.0 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealOrangeOne
approved these changes
Apr 6, 2021
jordaneb
reviewed
Apr 9, 2021
| import dj_database_url | ||
|
|
||
|
|
||
| DATABASE_URL = os.environ.get("DATABASE_URL", "sqlite:///:memory:") |
There was a problem hiding this comment.
Weirdly this is actually correct. See https://docs.sqlalchemy.org/en/14/dialects/sqlite.html#connect-strings for an explanation.
jordaneb
approved these changes
Apr 9, 2021
* origin/2.0: Django 3.2 final Add note on Django version support
Merged
|
Superceded by #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So.. this PR does quite a lot, and when it is released will be backwards incompatible. This was necessary to support anything newer than Django 2.2.
django-db-queue is now quite old, and relies on a bunch of unmaintained dependencies. This PR removes them all, at the cost of making the upgrade path a bit of a pain. Details are in the README but in short: you have to drop the jobs table and recreate it.
We now use the cross-database
JSONFieldimplementation that was added in Django 3.1, rather than a third-party unmaintained thing. I've also removed the dependency on my own simplesignals library (which I haven't touched in nine years!)I've removed some stuff that was never used (the
create_jobmanagement command (which didn't work anyway) and theJobSerializer, which I'd forgotten even existed.