Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

johncmacy
Copy link
Contributor

@johncmacy johncmacy commented Dec 5, 2021

Add support for Windows users, since Windows doesn't support the SIGQUIT signal.

Closes #46

Add support for Windows users, since Windows doesn't support the SIGQUIT signal.
@j4mie
Copy link
Member

j4mie commented Dec 6, 2021

Thanks for this! I'm a little bit hesitant to merge this as I don't use Windows, and so I would have no way of supporting this if anyone reported a bug. And setting up infrastructure to run the CI on Windows would also be a huge pain. On the other hand, it's a very small change... let me think about it a little!

@j4mie
Copy link
Member

j4mie commented Dec 6, 2021

Decided that we're happy to merge this. A couple of notes:

  1. The tests are failing because of black formatting, please run black django_dbq to fix.
  2. Please add a note at the bottom of the README (perhaps straight after the Testing section) along these lines:
## Windows support

Windows is supported on a best-effort basis only, and is not covered by automated or manual testing.

Thanks again 🙂

@j4mie
Copy link
Member

j4mie commented Dec 6, 2021

hey @johncmacy it looks like there's something very odd going on with Black. Could this be another Windows issue maybe? It looks like your Black and my Black are disagreeing.. 🤯

Would you like me to pick this PR up and try to resolve the formatting issues?

@johncmacy
Copy link
Contributor Author

@j4mie please do, I haven't used black before so not sure I'm going to be able to resolve it quickly. I wasn't able to pip install from test-requirements.txt either (some issue with psycopg2), so I am currently unable to run tests locally.

@j4mie
Copy link
Member

j4mie commented Dec 6, 2021

@johncmacy no problem, leave it with me!

@j4mie
Copy link
Member

j4mie commented Dec 6, 2021

Honestly I'm still a little confused by this, because it looks like Black has formatted a bit of code that you didn't even touch 🤔 oh well, it's passing now at least! Thanks again 🙂

@j4mie j4mie merged commit 6cd92cd into dabapps:master Dec 6, 2021
@johncmacy
Copy link
Contributor Author

Thank you for approving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: module 'signal' has no attribute 'SIGQUIT'
2 participants