Update CI and publish workflows for .NET versions #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove .NET 9.0 and 10.0 test runs from the CI workflow, keeping only .NET 8.0. Add .NET 10.0 test runs to the publish workflow. Also, remove the --no-build flag from the dotnet pack command in the CI workflow.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the CI workflow testing strategy by focusing on .NET 8.0 LTS while ensuring comprehensive multi-version testing in the publish workflow. The changes reduce CI runtime while maintaining thorough pre-release validation.
- Simplified CI workflow to test only .NET 8.0 for AOT compatibility
- Enhanced publish workflow by adding .NET 10.0 AOT test coverage
- Removed
--no-buildflag fromdotnet packcommand in CI to ensure proper package creation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Removed .NET 9.0 and 10.0 AOT test runs, keeping only .NET 8.0; removed --no-build flag from package creation |
.github/workflows/publish.yml |
Added .NET 10.0 AOT test execution to ensure all target frameworks are validated before publishing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Run Benchmarks | ||
| run: | | ||
| dotnet run -c Release -f net8.0 net9.0 net10.0 --project ./tests/Benchmark -- --filter "*" --exporters github --artifacts ./BenchmarkResults |
There was a problem hiding this comment.
The benchmark command references target frameworks net9.0 and net10.0, but the AOT tests for these frameworks have been removed from the CI workflow. This creates an inconsistency where the benchmarks will run for frameworks that aren't being tested for AOT compatibility in the same workflow. Consider either removing net9.0 and net10.0 from the benchmark command to match the removed AOT tests, or keeping the multi-framework testing approach consistent across both benchmarks and AOT tests.
Suggested change
| dotnet run -c Release -f net8.0 net9.0 net10.0 --project ./tests/Benchmark -- --filter "*" --exporters github --artifacts ./BenchmarkResults | |
| dotnet run -c Release -f net8.0 --project ./tests/Benchmark -- --filter "*" --exporters github --artifacts ./BenchmarkResults |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 99 99
Lines 2281 2281
Branches 241 241
=======================================
Hits 2246 2246
Misses 23 23
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove .NET 9.0 and 10.0 test runs from the CI workflow, keeping only .NET 8.0. Add .NET 10.0 test runs to the publish workflow. Also, remove the --no-build flag from the dotnet pack command in the CI workflow.