Remove --no-restore from build step in publish workflow #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build step in the publish workflow no longer uses the --no-restore flag, ensuring that dependencies are restored during the build process.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the --no-restore flag from the build step in the publish workflow, which causes dependencies to be restored twice: once explicitly at line 50 and again implicitly during the build at line 53.
Changes:
- Modified the build command to remove
--no-restoreflag, allowing the build step to perform its own dependency restoration
|
|
||
| - name: Build solution | ||
| run: dotnet build --configuration Release --no-restore | ||
| run: dotnet build --configuration Release |
There was a problem hiding this comment.
Removing the --no-restore flag causes redundant dependency restoration. Since dependencies are explicitly restored at line 50 with dotnet restore, the build step should use --no-restore to avoid restoring dependencies again. This improves build performance by skipping unnecessary work.
The recommended pattern is:
- Explicit
dotnet restore(line 50) dotnet build --no-restore(to skip redundant restore)dotnet test --no-build(to use build artifacts)
This change makes the build slower without providing any benefit.
Suggested change
| run: dotnet build --configuration Release | |
| run: dotnet build --configuration Release --no-restore |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 114 114
Lines 2365 2365
Branches 267 267
=======================================
Hits 2315 2315
Misses 30 30
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build step in the publish workflow no longer uses the --no-restore flag, ensuring that dependencies are restored during the build process.