Write Super Long Message Support(int.MaxValue to long.MaxValue) #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 97.88% 97.59% -0.29%
==========================================
Files 114 114
Lines 2365 2497 +132
Branches 267 280 +13
==========================================
+ Hits 2315 2437 +122
- Misses 30 38 +8
- Partials 20 22 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for serializing messages larger than int.MaxValue (2GB) by introducing CalculateLongSize methods throughout the codebase that return long instead of int.
Changes:
- Added
CalculateLongSize(long)methods toIProtoWriterandIProtoWriter<T>interfaces - Implemented
CalculateLongSizein all built-in parser types (primitives, collections, wrappers) - Updated code generator to emit
CalculateLongSizemethods for generated types - Added infrastructure methods
WriteLongLength,ComputeLongLengthSizefor writing long lengths - Added comprehensive tests including a test that creates a 5GB message to verify the functionality
Reviewed changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/LightProto/IProtoParser.cs | Added CalculateLongSize methods to IProtoWriter interfaces |
| src/LightProto/WriterContext.cs | Added WriteLongLength method for writing long length values |
| src/LightProto/WritingPrimitives.cs | Added WriteLongLength implementation |
| src/LightProto/CodedOutputStream.ComputeSize.cs | Added ComputeLongLengthSize for calculating varint size of long values |
| src/LightProto/RuntimeProtoWriter.cs | Implemented CalculateLongSize with overflow checking |
| src/LightProto/Serializer.*.cs | Updated serialization methods to use long sizes |
| src/LightProto/Parser/*.cs | Implemented CalculateLongSize in all parser types |
| src/LightProto.Generator/LightProtoGenerator.cs | Updated code generator to emit CalculateLongSize methods |
| tests/LightProto.Tests/LongLengthMessageTests.cs | New test for messages exceeding int.MaxValue |
| tests/LightProto.Tests/CollectionTest/*.cs | Added tests to verify CalculateLongSize returns same value as CalculateSize for small objects |
| tests/LightProto.Tests/CustomParser/*.cs | Updated custom parsers to implement CalculateLongSize |
| src/LightProto/PublicAPI/*.txt | Documented new public API surface |
This comment has been minimized.
This comment has been minimized.
Refactored size calculation methods to consistently use long-based calculations and removed redundant overflow checks. Added overflow checks and exceptions for serialization methods that could exceed array or prefix size limits. Expanded test coverage for large messages, including overflow scenarios and additional assertions for size calculation consistency.
Replaces calls to CalculateLongSize with CalculateSize in LongLengthMessageTests to reflect updated method naming or API changes.
This comment has been minimized.
This comment has been minimized.
Wrapped LongLengthMessageTest in a .NET 10 conditional to avoid out-of-memory issues in CI. Increased the number of items but reduced the size of each item's data to lower overall memory usage. Added explicit GC.Collect call and updated assertions accordingly.
This comment has been minimized.
This comment has been minimized.
Updated LongLengthMessageTests to include assertions for OverflowException when calculating sizes for large messages. Fixed a typo in the preprocessor directive for .NET 10. Added a KeyValuePair test case in NonGenericSerializerTests. Corrected method usage in IntergrationTests for CalculateLongSize.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.