Fix YAML deserializer to bind inherited properties in custom step types #1395
+90
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the YAML deserializer issue where custom step types inheriting from built-in steps (like
Foreach
) couldn't bind to inherited properties.Root Cause: In
DefinitionLoader.cs
line 225,stepType.GetProperty(input.Key)
only looks for properties declared in the exact type, not in base classes.Solution: Changed to
stepType.GetProperty(input.Key, BindingFlags.Public | BindingFlags.Instance)
which includes inherited public instance properties.Build Fix: Updated the integration test to use
A.Fake<IWorkflowRegistry>()
instead ofnew WorkflowRegistry()
to follow the existing test patterns and resolve the missing type reference.Test Coverage: Added integration test that verifies both:
RunParallel
fromForeach
can now be bound in custom step typesThe fix is minimal and surgical - only one line changed to use the proper BindingFlags overload. All existing tests pass, confirming no regression.
Fixes #1375.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.