Fix for www.baidu.com #13329
Fix for www.baidu.com #13329
Conversation
Fix for www.baidu.com
Fix errors
|
Update log:
|
|
There is an issue with this version, and this branch will be temporarily closed. |
Fix errors
|
The serious issue has been fixed and the pull request has been reopened! Update log:
Due to the complex style definition structure used by the developers of this website (For example, styles defined in |
Fix errors
Fix errors
Fix errors
Fix errors
Fix errors
|
First I just want to confirm it's done because it was closed, opened more fixed added after opening. If yes then I will try to go through it. 😉 |
|
Are these huge fixes required? If I remove all Baidu fixes completely, it looks perfect, except for one page where Dark Reader didn't process inline background image https://www.baidu.com/s?wd=%E5%8E%86%E5%8F%B2%E4%B8%8A%E7%9A%84%E4%BB%8A%E5%A4%A9 |
Yes, the code for this branch is already complete and can be merged. |
Can you show some before after like you did in the previous PR #13225 Because like Alexander wrote... Did we really need that much CSS in fixes? We try to keep fixes only for things that are not readable at all not making whole new CSS style to make page look perfect. (at least I am trying to keep it that way) |
Okay, here is a small selection of before and after effects for the fixes.
To make it easier to read, I used web translations in some of the images, but this may also cause issues with the website layout. Since this website is a search engine, a lot of content is only displayed when specific keywords are searched for, so some minor errors may not be noticed until after a few uses. Furthermore, the website has a huge user base in specific countries or regions, such as China, and I believe that these fixes will be very useful to many people. I also hope that this will help make the website more readable and user-friendly in Dark Reader's dark mode, which could help the extension receive more positive reviews. |
There was a problem hiding this comment.
First link you gave here: https://www.baidu.com/s?rtt=1&bsst=1&cl=2&tn=news&ie=utf-8&word=example
With your fixes:
Dark Scheme:
Light Scheme:
Without any fixes to www.baidu.com:
Dark Scheme:
Light Scheme:
This shows why making too big CSS fixes is not so welcome.
2nd link with your fixes: https://www.baidu.com/sf/vsearch?pd=video&wd=example
Dark Scheme:
Light Scheme:
Without any www.baidu.com fixes:
Dark Scheme
Light Scheme:
Again it's a point to not merge as with your CSS fixes there is some problems with light scheme.
I do not know why you make logo white as it looks fine without it.
My proposal is to do the big refactor here what is really needed and what is added because you wanted to have something lighter in dark mode.
If you don't like this option then at least check your CSS and not force color there but
use ${color} where the color is the original color to invert(100%) and hue-rotate(180deg). So example how to use this... Let's pretend you use some color now like #334455 instead if you want to have same effect you use ${#AABBCC}
like I already mentioned in PR #13255
Then after the changes push it here to review.
Optimize the code to utilize dynamic colors
|
Optimize the code to utilize dynamic colors, and fix errors. |
|
I will ask the same as @alexanderby last time.
Now even on this page I do not see any fixes needed. in sitefixes we try to have only necessary fixes and in this PR I see over 800 new lines which I do not know what they are really needed for as I can not see any urgent need for fixes on the pages which links was mentioned here. For me it's to reject in this form but I am leaving that decision to Alexander. |
Update log:
:hoverstyle errors of history and search prediction below the search box.