-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fixes for genius.com and nytimes.com #13693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
genius.com - Header: color, logo and signup link fix nytimes.com - Games hub: NYT Games logo, hamburger menu and progress icons fix - Letter Boxed: game icon fix - The Crossword: replaced some variable colors for cells with hex colors to match the color scheme to the android app in dark mode
|
First thing: Please share URLs we can check the differences before and after fixes. Summarizing: |
Can't seem to get [class^="puzzleProgress"]:not(puzzleProgress0) to work so I reverted to inefficient ugly but functional filtering
I'm still a little confused about the puzzleProgress fixes, reverted those for now
|
Sorry for the late reply. I have edited my original comment to add links, and I'll use separate pull requests next time. Thanks for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still I found some places to fix. But it's less than last time. 😉
| .vmap-layer-container > g > text | ||
| .vmap-zoom-buttons | ||
| #xwd-board | ||
| .pz-nav__logo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still some issue when switching from dark to light scheme and back in Dark Reader. This line should be removed.
Change this to .pz-nav__logo path
| #xwd-board path { | ||
| stroke: #171717 !important; | ||
| } | ||
| #js-logo-nav > svg > rect { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS for this selector should be removed. 😝
| fill: #000 !important; | ||
| } | ||
|
|
||
| IGNORE INLINE STYLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ti this section:
#js-logo-nav > svg > rect and the logo will work better in light/dark scheme.
| } | ||
| #xwd-board rect[class^="xwd__cell--cell"] { | ||
| fill: ${darkgrey} !important; | ||
| fill: #595963 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to have this color in dark scheme then use ${#ada59b} - this will do lighter cell in light scheme.
genius.com
https://genius.com/(sitewide)nytimes.com
https://www.nytimes.com/crosswordshttps://www.nytimes.com/crosswords/game/daily