This repository was archived by the owner on Jan 26, 2021. It is now read-only.
A number of cleanup commits #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakudrama
reviewed
Sep 20, 2018
| return x != ""; // return false; suppress unused variable warning | ||
| } catch (e) { | ||
| var checked = false; | ||
| assert(() { |
There was a problem hiding this comment.
This is not checking the same thing.
The code as originally written:
- in Dart 1 was checking for --checked.
- in Dart 2 was checking for --omit-implicit-checks when compiled with dart2js
Now it is checking for --enable-asserts.
So I expect a performance regression on 'production' apps.
There was a problem hiding this comment.
@rakudrama – suggestions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.