add BUILD_DART2JS_VM_ARGS environment variable support #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmundch
approved these changes
Nov 13, 2019
Member
sigmundch
left a comment
There was a problem hiding this comment.
To manually test it, I'd try something like passing --observe --print_metrics on a small program. That should show you a URI to open up observatory and it should also print extra data to stderr about memory utilization at the end.
There might be other flags that also print information, so you could potentially write tests that inspect stdout and stderr to look for the signal that the options are passed through.
natebosch
approved these changes
Nov 13, 2019
Contributor
Author
|
I was able to manually test this and it works - adding an actual test would require bumping the min constraint for build_modules in build_web_compilers which is probably not worth doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2543.
I haven't actually tested it yet, nor do I have any idea of how to write a test for it 😠.