Fix daemon_test.dart #3395
Merged
Fix daemon_test.dart #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That change is likely to break a whole lot more than this test..... |
|
I think that change likely requires some additional work in any package that spawns a dart isolate or program - at least if they do it from source? Do the compile commands still do the auto-detection? We rely on this auto detection all over the place. |
jakemac53
approved these changes
Oct 27, 2022
They will continue to do auto detection in Dart 2.19 and the CL that disables auto detection will land after the branch cut for the final beta of Dart 2.19. |
jakemac53
added a commit
that referenced
this pull request
Nov 30, 2022
simolus3
pushed a commit
to simolus3/build
that referenced
this pull request
Dec 11, 2022
…-lang#3415) This was removed in dart-lang#3395 but reverted in dart-lang#3411 (likely a bad merge). This just removes it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove @Dart specification from daemon_test.dart in preparation for https://dart-review.googlesource.com/c/sdk/+/261140.
This is based on the observation from @emmanuel-p