Track resolver dependencies as library cycle graphs #3996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
1dc9206 to
85e0861
Compare
236c9e8 to
cd06a75
Compare
cd06a75 to
96a18f7
Compare
jensjoha
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Track resolver dependencies as library cycle graphs; when invalidating, evaluate invalidation of resolved source by library cycles and graphs.
The phased library cycle graph is serialized after the build then used for invalidation in the next build.
Benchmarks show there is no longer quadratic growth in incremental build time or asset graph size. So after this performance improvements will be looking for constant factors--unless we find other ways to trigger slower-than-linear performance.
Add test coverage around interesting invalidation cases.