Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add back write caching. #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add back write caching. #4001

wants to merge 1 commit into from

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented May 8, 2025 •
edited
Loading

Retry of #3995.

Switch to sync I/O landed already in #4000.

Differences to #3995:

  • don't remove LruCache; this means writes need caching separately so they don't get evicted, cache in _Write class
  • noticed and fixed that deletes were being done to a writer with no cache; this seems to have sped things up a little bit (maybe a few percent), generated files are now written as new versions instead of deleted then written later

Fix copyWith for onCanReadController in the test ReaderWriter, as this now matters for one test.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025 •
edited
Loading

PR Health

@davidmorgan davidmorgan force-pushed the write-caching-again branch 2 times, most recently from 6aad9d7 to 016caae Compare May 8, 2025 10:44
@davidmorgan davidmorgan mentioned this pull request May 8, 2025
Closed
@davidmorgan davidmorgan force-pushed the write-caching-again branch 3 times, most recently from cf45807 to 7db501e Compare May 8, 2025 12:23
@davidmorgan davidmorgan force-pushed the write-caching-again branch from 7db501e to bd9b012 Compare May 8, 2025 13:49
@davidmorgan davidmorgan requested a review from jensjoha May 8, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensjoha jensjoha Awaiting requested review from jensjoha

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
skip-changelog-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidmorgan