Add a workflow for publishing flutter packages #1286
Conversation
Closes #1259 Add a second copy of the publish workflow with `use-flutter: true`. Add `ignore-packages` to both workflows to ignore published packages for the non-relevant SDK.
It looked like it was specified as a string, so I assumed we should use the comma separated format as if it were passed as a CLI arg, but that doesn't seem to have any effect.
Github actions don't support yaml lists?
Does the comment show up on the PR?
| @@ -12,6 +12,8 @@ jobs: | |||
| publish: | |||
| if: ${{ github.repository_owner == 'dart-lang' }} | |||
| uses: dart-lang/ecosystem/.github/workflows/publish.yaml@main | |||
| with: | |||
| ignore-packages: pkgs/cupertino_http,pkgs/cronet_http,pkgs/ok_http | |||
| permissions: | |||
| id-token: write # Required for authentication using OIDC | |||
There was a problem hiding this comment.
@devoncarew - Are these config lines stale? I don't see the same in the other repos I checked.
There was a problem hiding this comment.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
This reverts commit 35f8076.
| if: ${{ github.repository_owner == 'dart-lang' }} | ||
| uses: dart-lang/ecosystem/.github/workflows/publish.yaml@main | ||
| with: | ||
| use-flutter: true |
There was a problem hiding this comment.
Seems like something we should auto-detect, right? Maybe?
There was a problem hiding this comment.
It did initially, and then that functionality was removed.
dart-lang/ecosystem#158
I'm not sure I understand the "We need the flag anyhow to decide whether to setup Flutter in the first place" statement. @mosuem do you recall what this meant?
There was a problem hiding this comment.
It means that instead of setting up dart via setup-dart, we would use the setup-flutter action. To auto-detect, we would to implement that before running the dart setup, so in a bash script in the github workflow itself (or a dart script, by running an additional setup- step before).
|
Is this ready to land? |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
Closes #1259
Add a second copy of the publish workflow with
use-flutter: true.Add
ignore-packagesto both workflows to ignore published packages forthe non-relevant SDK.