Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[native_assets_cli] Remove lib/native_assets_cli_internal.dart #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

[native_assets_cli] Remove lib/native_assets_cli_internal.dart #2235

merged 1 commit into from
Apr 24, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Apr 24, 2025 •
edited
Loading

The only class that was exported from that file was only used in native_assets_builder, so this PR moves it there.

Bug:

Before we can address #999, we need to have an idea what the import structure should look like.

@github-actions GitHub Actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
native_assets_builder Breaking 0.17.0 0.18.0-wip 0.18.0 ✔️
native_assets_cli Breaking 0.17.0 0.18.0-wip 0.18.0 ✔️
native_toolchain_c Non-Breaking 0.14.0 0.15.0-wip 0.14.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 85.669% (+0.002%) from 85.667%
when pulling 3baf7eb on organize-imports-1
into b5c71ca on main.

@dcharkes dcharkes requested review from goderbauer and mosuem April 24, 2025 09:24
goderbauer
goderbauer approved these changes Apr 24, 2025
View reviewed changes
Copy link

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes merged commit e5c759e into main Apr 24, 2025
26 checks passed
@dcharkes dcharkes deleted the organize-imports-1 branch April 24, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@mosuem mosuem Awaiting requested review from mosuem

Assignees
No one assigned
Labels
package:hooks_runner package:hooks package:native_toolchain_c
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcharkes @coveralls @goderbauer