Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[native_toolchain_c] Make compatible with Firebase Studio #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[native_toolchain_c] Make compatible with Firebase Studio #2269

wants to merge 5 commits into from
+49 −6

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented May 6, 2025 •
edited
Loading

  • Adds the installation path of the Android NDK to the default installation paths. (It would be better if we got this from ANDROID_HOME or ANDROID_SDK_ROOT.)
  • Enables discovering llvm-ar and ld.lld on the PATH. They are in separate install locations in NixOS.
  • Prefer ld.lld over ld from GCC when not cross compiling in CLinker (more likely to be available).

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented May 6, 2025 •
edited
Loading

Coverage Status

coverage: 81.604% (+0.001%) from 81.603%
when pulling 14856b2 on firebase-studio
into 11966f1 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:native_toolchain_c skip-breaking-check skip-changelog-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcharkes @coveralls