[interop] Add support for Conditional and Predicate Types #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dart-lang#464 Fixes dart-lang#463 This PR adds support for transforming conditional types (`t extends a ? b : c`) and predicate types (`t is a`), and generates Dart alternatives to these types. Predicate types are converted to booleans, while conditional types are converted to unions, since the result can either be one or the other. There currently isn't a way (afaik) to introspect into parameter values to give a specific result depending on the param result. We could be smart, however, and wrap such methods with other methods to do the casting for us in the case of conditional types, and could _try_ to do similar in predicate types (via `assert` checks and more). Signed-off-by: Nike Okoronkwo <[email protected]>
srujzs
approved these changes
Sep 12, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 15, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. tools (https://github.com/dart-lang/tools/compare/319be98..4254267): 4254267d 2025-09-11 Devon Carew Update gemini config.yaml (dart-lang/tools#2162) 6cb8f0f7 2025-09-11 Devon Carew Update README.md (dart-lang/tools#2161) web (https://github.com/dart-lang/web/compare/e2daa3a..25a0b5b): 25a0b5b 2025-09-14 Nikechukwu [interop] Add support for Conditional and Predicate Types (dart-lang/web#468) Change-Id: I067ce2b7b48b2f57c145d49e2dad2dd2653ffb82 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449581 Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
Fixes #463
This PR adds support for transforming conditional types (
t extends a ? b : c) and predicate types (t is a), and generates Dart alternatives to these types.Predicate types are converted to booleans, while conditional types are converted to unions, since the result can either be one or the other. There currently isn't a way (afaik) to introspect into parameter values to give a specific result depending on the parameter result.
We could be smart, however, and wrap such methods with other methods to do the casting for us in the case of conditional types, and could try to do similar in predicate types (via
assertchecks and more).