Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Null safety cleanup in test runner code #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Null safety cleanup in test runner code #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68db1de
Null safety cleanup in test runner code
nshahan Jul 31, 2025
4006a2f
a few more cleanup bits
nshahan Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend_server_client/example/web_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ void main(List<String> args) async {
'--multi-root-scheme=org-dartlang-sdk',
'--modules=amd',
'--module-name=dart_sdk',
'--sound-null-safety',
'-o',
dartSdkJs,
p.url.join(sdkDir, sdkKernelPath),
Expand Down
4 changes: 0 additions & 4 deletions frontend_server_common/lib/src/devfs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class WebDevFS {
required this.projectDirectory,
required this.packageUriMapper,
required this.index,
this.soundNullSafety = true,
this.urlTunneler,
required this.sdkLayout,
required this.compilerOptions,
Expand All @@ -46,9 +45,6 @@ class WebDevFS {
List<Uri> sources = <Uri>[];
DateTime? lastCompiled;

@Deprecated('Only sound null safety is supported as of Dart 3.0')
final bool soundNullSafety;

final TestSdkLayout sdkLayout;
final CompilerOptions compilerOptions;

Expand Down
1 change: 0 additions & 1 deletion frontend_server_common/lib/src/frontend_server_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ class ResidentCompiler {
],
if (useDebuggerModuleNames) '--debugger-module-names',
'--experimental-emit-debug-metadata',
'--sound-null-safety',
for (final experiment in compilerOptions.experiments)
'--enable-experiment=$experiment',
if (compilerOptions.canaryFeatures) '--dartdevc-canary',
Expand Down
7 changes: 2 additions & 5 deletions test_common/lib/test_sdk_configuration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@ import 'package:test_common/test_sdk_layout.dart';
/// Implementation for SDK configuration for tests that can generate
/// missing assets.
///
/// - Generate SDK js, source map, and full dill (normally included in flutter
/// SDK or produced by build).
///
/// TODO(annagrin): update to only generating missing sound artifacts
/// for frontend server after we have no uses of weak null safety.
/// - Generate SDK js, source map (normally included in flutter SDK
/// or produced by build).
class TestSdkConfigurationProvider extends SdkConfigurationProvider {
final _logger = Logger('TestSdkConfigurationProvider');

Expand Down
Loading