Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pass script uri for javascript expression compilation #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Pass script uri for javascript expression compilation #2682

wants to merge 12 commits into from

Conversation

jensjoha
Copy link
Contributor

@jensjoha jensjoha commented Sep 2, 2025

Pass over the script uri (which when in parts is different from the library uri) when doing js expression evaluation.

@jensjoha
Copy link
Contributor Author

jensjoha commented Sep 5, 2025

I don't know if there's any process for bumping major versions and/or min dart sdk --- this does both (and as a consequence of going from language version 3.7 to 3.10 most of the changes are formatting --- would it make more sense to land a min sdk change with a formatting first?

@jensjoha jensjoha requested review from biggs0125 and bkonyi September 5, 2025 12:37
@bkonyi
Copy link
Collaborator

bkonyi commented Sep 8, 2025

I don't know if there's any process for bumping major versions and/or min dart sdk --- this does both (and as a consequence of going from language version 3.7 to 3.10 most of the changes are formatting --- would it make more sense to land a min sdk change with a formatting first?

Yeah, let's land a formatting change first. I have a WIP PR that I'll pick up to do that.

@bkonyi
Copy link
Collaborator

bkonyi commented Sep 8, 2025

Let's wait for #2662 to land.

@biggs0125
Copy link
Contributor

Please send a ping when the formatting changes are landed and this is rebased so this change is easier to review. Thanks :)

@bkonyi
Copy link
Collaborator

bkonyi commented Sep 22, 2025

Sorry for the delay on the formatting PR @jensjoha. We should be good to move forward with this PR now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biggs0125 biggs0125 Awaiting requested review from biggs0125

@bkonyi bkonyi Awaiting requested review from bkonyi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dart-debug-extension package:dwds package:frontend_server_client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jensjoha @bkonyi @biggs0125