Update bokeh plots #628
Update bokeh plots #628
Conversation
mrocklin
commented
Nov 6, 2016
- Fix size of memory plot
- Add height of task stream plot (maybe not a good idea)
* Fix size of memory plot * Add height of task stream plot (maybe not a good idea)
facd032 to
7d3ca2a
Compare
|
cc @canavandl can you give this four-line PR a quick glance to check if anything seems off to you? |
distributed/bokeh/components.py
Outdated
|
|
||
| mem_plot.add_layout(LinearAxis(), 'left') | ||
| mem_plot.add_layout(LinearAxis(), 'below') | ||
| mem_plot.yaxis.visible = False |
There was a problem hiding this comment.
remove L403 instead (so that axis isn't added)
|
What's the intent of settings the plot_height in the element constructor instead of passing it in as a kwarg? I think doing so might impact the responsive resizing for JLab |
|
Currently in the workers/ pane the Similarly we're getting strange effects when the user presses "reset" on the task stream plot in the status/ page. The plot increases in vertical size. |
|
I think you should be able to constrain the mem_plot size by passing I'll look into the task stream plot. |
|
It appears that ResetTool accepts a (and maybe here for good measure? https://github.com/dask/distributed/blob/master/distributed/bokeh/components.py#L317) I'll reproduce and open a Bokeh issue |
* move plot_height kwarg from components to workers/main.py * remove y axis from memory plot * Add reset_size=False to ResetTool
e001323 to
9047d47
Compare
|
Changes applied. Lookin' sharp. |
distributed/bokeh/components.py
Outdated
| title=Title(text="Task Stream"), id='bk-task-stream-plot', | ||
| x_range=x_range, y_range=y_range, toolbar_location="above", | ||
| min_border_right=35, **kwargs | ||
| min_border_right=35, plot_height=300, **kwargs |
There was a problem hiding this comment.
I've removed it entirely. This was only here as a hack to avoid the reset issue
|
LGTM |